chore: cherry-pick 7e5c7b5964 from v8 #25646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miniak
force-pushed
the
cherry-pick/8-x-y/v8/f1031d8fd0
branch
from
bb15ac6
to
f09d78b
Compare
nornagon
approved these changes
Sep 29, 2020
zcbenz
requested changes
Oct 5, 2020
There was a problem hiding this comment.
CI requires this patch to be updated:
======================================================================
There were changes to the patches when applying.
Check the CI artifacts for a patch you can apply to fix it.
======================================================================
f09d78b
to
7db5b4f
Compare
miniak
force-pushed
the
cherry-pick/8-x-y/v8/f1031d8fd0
branch
from
7db5b4f
to
227b14a
Compare
zcbenz
approved these changes
Oct 9, 2020
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[compiler] Fix bug in SimplifiedLowering's overflow computation
It's unsound to ignore -0 inputs:
-0 - INT32_MIN is outside of INT32 range.
Bug: chromium:1126249
Change-Id: I3b92f16c1201705780acb0359975329aa2ca34d1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2404452
Reviewed-by: Tobias Tebbi tebbi@chromium.org
Commit-Queue: Georg Neis neis@chromium.org
Cr-Commit-Position: refs/heads/master@{#69877}
Notes: Security: backported fix for 1126249.